6252 ld should merge function/data-sections in the same manner as GNU ld

Review Request #99 — Created Sept. 21, 2015 and submitted

richlowe
illumos-gate
6252
c462b94...
general
alp, jeffpc
6252 ld should merge function/data-sections in the same manner as GNU ld

Tests with sample objects.
alp build firefox and node for me, and got good results
jperkin rebuilt pkgsrc and got good results
jeffpc built the nexenta stuff and got good results.

  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
tsoome
  1. 
      
  2. usr/src/cmd/sgs/libld/common/place.c (Diff revision 1)
     
     

    extra spaces (not tabs) there?

    1. Reviewboard seems to think so, emacs disagrees. Perhaps I fixed it already and forgot? Should (I hope) vanish when I publish an update for Hans

  3. 
      
hans
  1. 
      
  2. usr/src/cmd/sgs/libld/common/place.c (Diff revision 1)
     
     
     

    I don't understand this, could you rephrase that?

    1. What I mean is that should we have a symbol some_symbol we'd have .data.rel.ro.some_symbol to represent some_symbol's contribution to .data.rel.ro.

      As you can tell, I still can't find great ways to phrase this. Does the above make sense to you? Would something based on that work? Do you have ideas?

    2. I updated the comment, though not in the way either of us suggested. Do you like this one more?

  3. 
      
igork
  1. Ship It!
  2. 
      
richlowe
tsoome
  1. Ship It!
  2. 
      
jeffpc
  1. Ship It!
  2. 
      
trisk
  1. Ship It!
  2. 
      
richlowe
Review request changed

Status: Closed (submitted)

Loading...