6252 ld should merge function/data-sections in the same manner as GNU ld

Review Request #99 — Created Sept. 21, 2015 and submitted Sept. 28, 2015, 3:06 p.m.

Information
Owner:	richlowe
Repository:	illumos-gate
Branch:
Bugs:	6252
Depends On:
Commit:	c462b94...
Reviewers
Groups:	general
People:	alp, jeffpc

Description

6252 ld should merge function/data-sections in the same manner as GNU ld

Testing Done

Tests with sample objects.
alp build firefox and node for me, and got good results
jperkin rebuilt pkgsrc and got good results
jeffpc built the nexenta stuff and got good results.

Issues

0
0
2
0
All Issues: 2

Description	From	Last Updated
I don't understand this, could you rephrase that?	hans	Sept. 28, 2015, 3:05 p.m.
extra spaces (not tabs) there?	tsoome	Sept. 23, 2015, 9:45 p.m.

usr/src/cmd/sgs/libld/common/place.c (Diff revision 1)

Show all issues

extra spaces (not tabs) there?

richlowe Sept. 22, 2015, 10:04 p.m.

Reviewboard seems to think so, emacs disagrees. Perhaps I fixed it already and forgot? Should (I hope) vanish when I publish an update for Hans

usr/src/cmd/sgs/libld/common/place.c (Diff revision 1)

Show all issues

I don't understand this, could you rephrase that?

richlowe Sept. 23, 2015, 4:11 p.m.

What I mean is that should we have a symbol some_symbol we'd have .data.rel.ro.some_symbol to represent some_symbol's contribution to .data.rel.ro.

As you can tell, I still can't find great ways to phrase this. Does the above make sense to you? Would something based on that work? Do you have ideas?

richlowe Sept. 23, 2015, 9:46 p.m.

I updated the comment, though not in the way either of us suggested. Do you like this one more?