3328 smbutil view does't work with Win2008 and later

Review Request #983 — Created March 19, 2018 and submitted

gwr
illumos-gate
3328
general

3328 smbutil view does't work with Win2008 and later

Note: Requires 1575, also up for review in: https://www.illumos.org/rb/r/982/

Run "smbutil view //server" against a modern Windows, i.e.

$ smbutil view //w530gwr
Password:
Share        Type       Comment
-------------------------------
ADMIN$       disk       Remote Admin
C$           disk       Default share
g            disk       
IPC$         IPC        Remote IPC
Junk         disk       
print$       disk       Printer Drivers
public       disk       
Users        disk       
  • 0
  • 0
  • 4
  • 1
  • 5
Description From Last Updated
gwr
gwr
tsoome
  1. 
      
  2. cstyle police:) it is good to have red markers...

  3. cstyle police again.

  4. also cstyle here..

  5. usr/src/cmd/fs.d/smbclnt/smbutil/view.c (Diff revision 1)
     
     

    and finally, here.

  6. 
      
gwr
mbarden
  1. 
      
  2. Is there a reason this is an 'INOUT', when the interface description above describes it as only an 'IN'?

    The union is also and 'INOUT', when the interface description describes it as an 'OUT'

    1. I don't know. I simply copied the few things this needs from the server srvsvc.ndl
      It looks the same over there.
      http://src.illumos.org/source/xref/illumos-gate/usr/src/uts/common/smbsrv/ndl/srvsvc.ndl#1349
      I'm hesitant to change these since this is all mature code with some test mileage.

    2. Weird. I guess that's OK then.

  3. 
      
mbarden
  1. Ship It!
  2. 
      
evanl
  1. Ship It!
  2. 
      
gwr
Review request changed

Status: Closed (submitted)

Loading...