1575 untangle libmlrpc ... (in 6 parts)

Review Request #982 — Created March 19, 2018 and submitted

gwr
illumos-gate
1575
general

1575 untangle libmlrpc from SMB server

This is easiest to review in separate chunks.
I've uploaded this as a sequence of six changes so you can position the review board diff sliders to show one diff at a time.
Those six changes are also here, as webrevs:
http://cr.illumos.org/~webrev/gwr/smbcl-rpc/

There's actually very little new code here.
This work is mostly just a re-factoring, but diffs make it look large.
In particular, all the code in the new file: usr/src/lib/libmlrpc/common/mlrpc_clh.c
was pulled out of usr/src/lib/smbsrv/libmlsvc/common/mlsvc_client.c

I've already fixed the "space tab" sequences. (in the last diff)
So apparently reviewboard is confused by what I've done.
I double checked all the space-tab sequences are gone,
and updated the diff, but RB still shows them. (sigh)
OK, made a new review: https://www.illumos.org/rb/r/984
(one big commit) and in there things now show up as fixed.
I'm putting any follow-up changes over there as this one
doesn't seem to show changes when I add more.

Joined SMB server to a domain, and used "smbadm lookup" to verify the outbound RPC functionality.
The easiest test is "smbutil view", after the changes in the related review: https://www.illumos.org/rb/r/983/

gwr
gwr
gwr
gwr
gwr
gwr
gwr
gwr
gwr
gwr
gwr
gwr
gwr
gwr
tsoome
  1. Iwould really be nice also to clean up the red ugliness, but ... shoot:)

    1. I thought I did, but with how I split up this review, it's not necessarily showing that when I add changes to the end.

  2. 
      
gwr
gwr
gwr
gwr
  1. 
      
  2. usr/src/lib/libmlrpc/Makefile.com (Diff revision 7)
     
     

    This is NOT what is in the latest commit.
    I fixed the space+tab, here and everywhere.
    (Grumble).

  3. 
      
gwr
gwr
gwr
mbarden
  1. 
      
  2. 
      
evanl
  1. Ship It!
  2. 
      
gwr
Review request changed

Status: Closed (submitted)

Loading...