as mentioned on irc, the userdel -z/-Z seem to overcomplicate the behaviour - I would rather think the -r is enough there. Not an blocker by me, but something to think about.

I'm also still not convinced its good idea to fail back silently to mkdir() if the intention was to create zfs dataset for home. At least there should be message about fallback, but I think the error would be more appropriate - afterall the dataset was requested, and if the useradd is unable to provide it, it should give an error.

Ship It!

Extra spaces

I'm not sure the meaning of the CHANGE_ZFS_FS option name is obvious, maybe MANAGE_ZFS or simply ENABLE_ZFS. Also looks like the value should be YES.

"If the user's home directory is located on a separate ZFS filesystem and the \fB/etc/default/useradd\fR file contains the parameter \fBxxx\fR set to the value \fBYES\fR, the file system will be destroyed.
If \fB-z\fR option is specified, \fBuserdel\fR will always try to destroy an existing file system for the home directory.

If \fB-Z\fR option is specified, an existing file system will never be destroyed.

"Avoided"

"If the parent directory of the user's home directory is located on a separate \fBZFS\fR

file system and the \fB/etc/default/useradd\fR file contains the parameter

\fBMANAGE_ZFS\fR set to the value \fBYES\f, a new ZFS filesystem will be created

for the user.

If \fB-z\fR option is specified, \fBuseradd\fR will always try to create a new

file system for the home directory.

If \fB-Z\fR option is specified, a new file system will never be created."

Suggest adding "\fBzfs\fR(1M)" here, as well as to SEE ALSO in the other manpages.

"If the user's home directory is located on a separate ZFS file system and the \fB/etc/default/useradd\fR file contains the parameter \fBMANAGE_ZFS\fR set to the value \fBYES\fR, the file system will be destroyed.

"If the user's home directory is located on a separate \fBZFS\fR file system and the

\fB/etc/default/useradd\fR file contains the parameter \fBMANAGE_ZFS\fB set to the

value \fBYES\fB, the file system will be destroyed."

Suggest adding "\fBzfs\fR(1M)" to the SEE ALSO list.

"If the user's old home directory was located on a separate \fBZFS\fR file system and the

\fB/etc/default/useradd\fR file contains the parameter \fBMANAGE_ZFS\fR set to the

value \fBYES\fR, the file system will be destroyed after the home directory is moved.

If parent directory of the user's new home directory is located on a separate ZFS file system and the \fB/etc/default/useradd\fR file contains the parameter

\fBMANAGE_ZFS\fR set to the value \fBYES\fR, a new ZFS file system will be created.

If \fB-z\fR option is specified, \fBusermod\fR will always try to create a new

file system for the home directory and destroy the old one.

If \fB-Z\fR option is specified, a new file system will never be created, and old

one will never be destroyed."

Same as others for SEE ALSO.

Last set of minor grammar and formatting issues in the manpage. Feel free to leave strncmp if you don't want to change it.

strcmp is appropriate here, as it is guaranteed to terminate after reading at most strlen("/") + 1 characters.

strcmp is also safe here.

```.sp

If the parent directory of the user's home directory is located on a separate

\fBZFS\fR file system and the \fB/etc/default/useradd\fR file contains the

parameter \fBMANAGE_ZFS\fR set to the value \fBYES\fR, a new \fBZFS\fR

file system will be created for the user.
If the \fB-z\fR option is specified, \fBuseradd\fR will always try to create a new

file system for the home directory.

.sp

If the \fB-Z\fR option is specified, a new file system will never be created.```
"If the" and "file system" (to be consistent with rest of man page), and .sp  for paragraph separators (please verify the .RS indent is consistent with the previous lines when viewed, my troff is not very good)

\fBZFS\fR file system, and .sp between the paragraphs.

.sp
If the user's old home directory was located on a separate \fBZFS\fR file system
and the \fB/etc/default/useradd\fR file contains the parameter \fBMANAGE_ZFS\fR
set to the value \fBYES\fR, the file system will be destroyed after the home
directory is moved. If parent directory of the user's new home directory is
located on a separate \fBZFS\fR filesystem and the \fB/etc/default/useradd\fR
file contains the parameter \fBMANAGE_ZFS\fR set to the value \fBYES\fR, a new
\fBZFS\fR filesystem will be created.
.sp
If the \fB-z\fR option is specified, \fBusermod\fR will always try to create a new
file system for the home directory and destroy the old one.
.sp
If the \fB-Z\fR option is specified, a new file system will never be created, and the old
one will never be destroyed.


(sorry, think this is the last time :)

Ship It!

Ship It!