Change Summary:
Include man page update.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+321 -408) |
Review Request #966 — Created March 20, 2018 and submitted
Information | |
---|---|
citrus | |
illumos-gate | |
master | |
5159 | |
9fd96de... | |
Reviewers | |
general | |
5159 ipsec_libssl_setup.c loads libcrypto
Work by Jason King.
See https://illumos.org/rb/r/966/bugs/5159/ for details of testing done.
Include man page update.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+321 -408) |
usr/src/lib/libkmf/libkmf/common/rdn_parser.c (Diff revision 2) |
---|
(I've been working on LDAP servers since the 1990s.) Although you're trying to follow LDAP RFCs for formatting the DN (good!) it looks like you're outputting the RDNs backwards. LDAP DNs are "little endian", so you should reverse the loop. I would also separate the RDNs with a plain "," and lose the extra space. IOW currently you'd output this DN: c=US, o=illumos, cn=server but this would be correct: cn=server,o=illumos,c=US Having the wrong order of RDNs is a significant problem, but easy to fix.
usr/src/lib/libkmf/libkmf/common/rdn_parser.c (Diff revision 2) |
---|
The custr... stuff is cool and all, but is it worth dragging in libcmdutils here to get it?
Did you consider making a pass over the RDNs here
and estimating the output buffer space required?
Then you could allocate that buffer here and
pass it as (... buf, len) to the other functions
in here to fill that in. Better?
Use libcustr instead of libcmdutils to avoid pulling in additional dependencies.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+321 -408) |
pbchk nits.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+324 -414) |