6185 want ficl scripting engine in illumos (loader project)

Review Request #92 — Created Sept. 2, 2015 and submitted

tsoome
illumos-gate
6185
86bdf93...
general
6185 want ficl scripting engine in illumos (loader project)
test results from 32/64 bit sparc and x86 versions:

tsoome@bld03:~/dilos-illumos/usr/src/common/ficl/test$ LD_LIBRARY_PATH=../../../lib/libficl/sparc ../../../cmd/ficl/sparc/ficl   ficltest.fr 
loading CORE EXT words 
loading SEARCH & SEARCH-EXT words 
loading Johns-Hopkins locals 
loading MARKER 
Ficl version 4.1.0
Sep  1 2015 
loading ficltest.fr 
TESTING CORE WORDS
TESTING BASIC ASSUMPTIONS
TESTING BOOLEANS: INVERT AND OR XOR
TESTING 2* 2/ LSHIFT RSHIFT
TESTING COMPARISONS: 0= = 0< < > U< MIN MAX
TESTING STACK OPS: 2DROP 2DUP 2OVER 2SWAP ?DUP DEPTH DROP DUP OVER ROT SWAP
TESTING >R R> R@
TESTING ADD/SUBTRACT: + - 1+ 1- ABS NEGATE
TESTING MULTIPLY: S>D * M* UM*
TESTING DIVIDE: FM/MOD SM/REM UM/MOD */ */MOD / /MOD MOD
TESTING HERE , @ ! CELL+ CELLS C, C@ C! CHARS 2@ 2! ALIGN ALIGNED +! ALLOT
TESTING CHAR [CHAR] [ ] BL S"
TESTING ' ['] FIND EXECUTE IMMEDIATE COUNT LITERAL POSTPONE STATE
TESTING IF ELSE THEN BEGIN WHILE REPEAT UNTIL RECURSE
TESTING DO LOOP +LOOP I J UNLOOP LEAVE EXIT
TESTING DEFINING WORDS: : ; CONSTANT VARIABLE CREATE DOES> >BODY
TESTING EVALUATE
TESTING SOURCE >IN WORD
TESTING <# # #S #> HOLD SIGN BASE >NUMBER HEX DECIMAL
TESTING FILL MOVE
TESTING OUTPUT: . ." CR EMIT SPACE SPACES TYPE U.
YOU SHOULD SEE THE STANDARD GRAPHIC CHARACTERS:
 !"#$%&'()*+,-./0123456789:;<=>?@
ABCDEFGHIJKLMNOPQRSTUVWXYZ[\]^_`
abcdefghijklmnopqrstuvwxyz{|}~
YOU SHOULD SEE 0-9 SEPARATED BY A SPACE:
0 1 2 3 4 5 6 7 8 9 
YOU SHOULD SEE 0-9 (WITH NO SPACES):
0123456789
YOU SHOULD SEE A-G SEPARATED BY A SPACE:
A B C D E F G 
YOU SHOULD SEE 0-5 SEPARATED BY TWO SPACES:
0  1  2  3  4  5  
YOU SHOULD SEE TWO SEPARATE LINES:
LINE 1
LINE 2
YOU SHOULD SEE THE NUMBER RANGES OF SIGNED AND UNSIGNED NUMBERS:
  SIGNED: 80000000 7FFFFFFF 
UNSIGNED: 0 FFFFFFFF 
TESTING INPUT: ACCEPT

PLEASE TYPE UP TO 80 CHARACTERS:
ksajdhfkjdshf

RECEIVED: "ksajdhfkjdshf"
TESTING DICTIONARY SEARCH RULES
testing 2>r 2r> 2r@
testing locals
testing :noname
testing default search order
testing forget
testing within
testing exception words
testing refill
testing prefixes
testing number builder

ok bye
tsoome@bld03:~/dilos-illumos/usr/src/common/ficl/test$ LD_LIBRARY_PATH=../../../lib/libficl/sparcv9/ ../../../cmd/ficl/sparcv9/ficl   ficltest.fr 
loading CORE EXT words 
loading SEARCH & SEARCH-EXT words 
loading Johns-Hopkins locals 
loading MARKER 
Ficl version 4.1.0
Sep  1 2015 
loading ficltest.fr 
TESTING CORE WORDS
TESTING BASIC ASSUMPTIONS
TESTING BOOLEANS: INVERT AND OR XOR
TESTING 2* 2/ LSHIFT RSHIFT
TESTING COMPARISONS: 0= = 0< < > U< MIN MAX
TESTING STACK OPS: 2DROP 2DUP 2OVER 2SWAP ?DUP DEPTH DROP DUP OVER ROT SWAP
TESTING >R R> R@
TESTING ADD/SUBTRACT: + - 1+ 1- ABS NEGATE
TESTING MULTIPLY: S>D * M* UM*
TESTING DIVIDE: FM/MOD SM/REM UM/MOD */ */MOD / /MOD MOD
TESTING HERE , @ ! CELL+ CELLS C, C@ C! CHARS 2@ 2! ALIGN ALIGNED +! ALLOT
TESTING CHAR [CHAR] [ ] BL S"
TESTING ' ['] FIND EXECUTE IMMEDIATE COUNT LITERAL POSTPONE STATE
TESTING IF ELSE THEN BEGIN WHILE REPEAT UNTIL RECURSE
TESTING DO LOOP +LOOP I J UNLOOP LEAVE EXIT
TESTING DEFINING WORDS: : ; CONSTANT VARIABLE CREATE DOES> >BODY
TESTING EVALUATE
TESTING SOURCE >IN WORD
TESTING <# # #S #> HOLD SIGN BASE >NUMBER HEX DECIMAL
TESTING FILL MOVE
TESTING OUTPUT: . ." CR EMIT SPACE SPACES TYPE U.
YOU SHOULD SEE THE STANDARD GRAPHIC CHARACTERS:
 !"#$%&'()*+,-./0123456789:;<=>?@
ABCDEFGHIJKLMNOPQRSTUVWXYZ[\]^_`
abcdefghijklmnopqrstuvwxyz{|}~
YOU SHOULD SEE 0-9 SEPARATED BY A SPACE:
0 1 2 3 4 5 6 7 8 9 
YOU SHOULD SEE 0-9 (WITH NO SPACES):
0123456789
YOU SHOULD SEE A-G SEPARATED BY A SPACE:
A B C D E F G 
YOU SHOULD SEE 0-5 SEPARATED BY TWO SPACES:
0  1  2  3  4  5  
YOU SHOULD SEE TWO SEPARATE LINES:
LINE 1
LINE 2
YOU SHOULD SEE THE NUMBER RANGES OF SIGNED AND UNSIGNED NUMBERS:
  SIGNED: 8000000000000000 7FFFFFFFFFFFFFFF 
UNSIGNED: 0 FFFFFFFFFFFFFFFF 
TESTING INPUT: ACCEPT

PLEASE TYPE UP TO 80 CHARACTERS:
lkasfjlkdsjfa

RECEIVED: "lkasfjlkdsjfa"
TESTING DICTIONARY SEARCH RULES
testing 2>r 2r> 2r@
testing locals
testing :noname
testing default search order
testing forget
testing within
testing exception words
testing refill
testing prefixes
testing number builder

ok bye

tsoome@openindiana:/code/illumos-gate/usr/src/common/ficl/test$ LD_LIBRARY_PATH=../../../lib/libficl/i386 ../../../cmd/ficl/i386/ficl ficltest.fr 
loading CORE EXT words 
loading SEARCH & SEARCH-EXT words 
loading Johns-Hopkins locals 
loading MARKER 
Ficl version 4.1.0
Sep  1 2015 
loading ficltest.fr 
TESTING CORE WORDS
TESTING BASIC ASSUMPTIONS
TESTING BOOLEANS: INVERT AND OR XOR
TESTING 2* 2/ LSHIFT RSHIFT
TESTING COMPARISONS: 0= = 0< < > U< MIN MAX
TESTING STACK OPS: 2DROP 2DUP 2OVER 2SWAP ?DUP DEPTH DROP DUP OVER ROT SWAP
TESTING >R R> R@
TESTING ADD/SUBTRACT: + - 1+ 1- ABS NEGATE
TESTING MULTIPLY: S>D * M* UM*
TESTING DIVIDE: FM/MOD SM/REM UM/MOD */ */MOD / /MOD MOD
TESTING HERE , @ ! CELL+ CELLS C, C@ C! CHARS 2@ 2! ALIGN ALIGNED +! ALLOT
TESTING CHAR [CHAR] [ ] BL S"
TESTING ' ['] FIND EXECUTE IMMEDIATE COUNT LITERAL POSTPONE STATE
TESTING IF ELSE THEN BEGIN WHILE REPEAT UNTIL RECURSE
TESTING DO LOOP +LOOP I J UNLOOP LEAVE EXIT
TESTING DEFINING WORDS: : ; CONSTANT VARIABLE CREATE DOES> >BODY
TESTING EVALUATE
TESTING SOURCE >IN WORD
TESTING <# # #S #> HOLD SIGN BASE >NUMBER HEX DECIMAL
TESTING FILL MOVE
TESTING OUTPUT: . ." CR EMIT SPACE SPACES TYPE U.
YOU SHOULD SEE THE STANDARD GRAPHIC CHARACTERS:
 !"#$%&'()*+,-./0123456789:;<=>?@
ABCDEFGHIJKLMNOPQRSTUVWXYZ[\]^_`
abcdefghijklmnopqrstuvwxyz{|}~
YOU SHOULD SEE 0-9 SEPARATED BY A SPACE:
0 1 2 3 4 5 6 7 8 9 
YOU SHOULD SEE 0-9 (WITH NO SPACES):
0123456789
YOU SHOULD SEE A-G SEPARATED BY A SPACE:
A B C D E F G 
YOU SHOULD SEE 0-5 SEPARATED BY TWO SPACES:
0  1  2  3  4  5  
YOU SHOULD SEE TWO SEPARATE LINES:
LINE 1
LINE 2
YOU SHOULD SEE THE NUMBER RANGES OF SIGNED AND UNSIGNED NUMBERS:
  SIGNED: 80000000 7FFFFFFF 
UNSIGNED: 0 FFFFFFFF 
TESTING INPUT: ACCEPT

PLEASE TYPE UP TO 80 CHARACTERS:
akafjhds

RECEIVED: "akafjhds"
TESTING DICTIONARY SEARCH RULES
testing 2>r 2r> 2r@
testing locals
testing :noname
testing default search order
testing forget
testing within
testing exception words
testing refill
testing prefixes
testing number builder

ok 

tsoome@openindiana:/code/illumos-gate/usr/src/common/ficl/test$ LD_LIBRARY_PATH=../../../lib/libficl/amd64/ ../../../cmd/ficl/amd64/ficl ficltest.fr 
loading CORE EXT words 
loading SEARCH & SEARCH-EXT words 
loading Johns-Hopkins locals 
loading MARKER 
Ficl version 4.1.0
Sep  1 2015 
loading ficltest.fr 
TESTING CORE WORDS
TESTING BASIC ASSUMPTIONS
TESTING BOOLEANS: INVERT AND OR XOR
TESTING 2* 2/ LSHIFT RSHIFT
TESTING COMPARISONS: 0= = 0< < > U< MIN MAX
TESTING STACK OPS: 2DROP 2DUP 2OVER 2SWAP ?DUP DEPTH DROP DUP OVER ROT SWAP
TESTING >R R> R@
TESTING ADD/SUBTRACT: + - 1+ 1- ABS NEGATE
TESTING MULTIPLY: S>D * M* UM*
TESTING DIVIDE: FM/MOD SM/REM UM/MOD */ */MOD / /MOD MOD
TESTING HERE , @ ! CELL+ CELLS C, C@ C! CHARS 2@ 2! ALIGN ALIGNED +! ALLOT
TESTING CHAR [CHAR] [ ] BL S"
TESTING ' ['] FIND EXECUTE IMMEDIATE COUNT LITERAL POSTPONE STATE
TESTING IF ELSE THEN BEGIN WHILE REPEAT UNTIL RECURSE
TESTING DO LOOP +LOOP I J UNLOOP LEAVE EXIT
TESTING DEFINING WORDS: : ; CONSTANT VARIABLE CREATE DOES> >BODY
TESTING EVALUATE
TESTING SOURCE >IN WORD
TESTING <# # #S #> HOLD SIGN BASE >NUMBER HEX DECIMAL
TESTING FILL MOVE
TESTING OUTPUT: . ." CR EMIT SPACE SPACES TYPE U.
YOU SHOULD SEE THE STANDARD GRAPHIC CHARACTERS:
 !"#$%&'()*+,-./0123456789:;<=>?@
ABCDEFGHIJKLMNOPQRSTUVWXYZ[\]^_`
abcdefghijklmnopqrstuvwxyz{|}~
YOU SHOULD SEE 0-9 SEPARATED BY A SPACE:
0 1 2 3 4 5 6 7 8 9 
YOU SHOULD SEE 0-9 (WITH NO SPACES):
0123456789
YOU SHOULD SEE A-G SEPARATED BY A SPACE:
A B C D E F G 
YOU SHOULD SEE 0-5 SEPARATED BY TWO SPACES:
0  1  2  3  4  5  
YOU SHOULD SEE TWO SEPARATE LINES:
LINE 1
LINE 2
YOU SHOULD SEE THE NUMBER RANGES OF SIGNED AND UNSIGNED NUMBERS:
  SIGNED: 8000000000000000 7FFFFFFFFFFFFFFF 
UNSIGNED: 0 FFFFFFFFFFFFFFFF 
TESTING INPUT: ACCEPT

PLEASE TYPE UP TO 80 CHARACTERS:
lkasdfjkldf

RECEIVED: "lkasdfjkldf"
TESTING DICTIONARY SEARCH RULES
testing 2>r 2r> 2r@
testing locals
testing :noname
testing default search order
testing forget
testing within
testing exception words
testing refill
testing prefixes
testing number builder

ok 

issues fixed (compared to first publish to webrev)

unneeded contrib and doc directories removed
removed unneeded dependency target from manifest
fixed loading files with relative path
fixed 64bit UM* u-m-star
accept is reading input from terminal
tests are using include instead of load
fixed test for double number, the high word should be at top of the stack
  • 0
  • 0
  • 6
  • 0
  • 6
Description From Last Updated
tsoome
tsoome
tsoome
tsoome
tsoome
tsoome
tsoome
tsoome
tsoome
tsoome
tsoome
tsoome
tsoome
tsoome
tsoome
tsoome
tsoome
tsoome
tsoome
tsoome
tsoome
tsoome
tsoome
tsoome
tsoome
tsoome
tsoome
richlowe
  1. 
      
  2. usr/src/cmd/ficl/Makefile.com (Diff revision 24)
     
     

    include Makefile.ctf?

  3. usr/src/lib/Makefile (Diff revision 24)
     
     

    Surely there are dependencies you need to express too?

  4. usr/src/lib/libficl/Makefile (Diff revision 24)
     
     

    RB is whining about spaces here, so I might as well too.

  5. usr/src/lib/libficl/ficllocal.h (Diff revision 24)
     
     

    What's the point of this header?

    1. It is there to provide local feature enable/disable statements, and is included by ficl.h as part of build process. For ficl in userspace we do not need any settings there, hence its empty. However, the loader does use it to disable float support in ficl, as floats are not supported in standalone. It is a bit awkward, but I did not want to change ficl logic there.

  6. usr/src/lib/libficl/mapfile-vers (Diff revision 24)
     
     

    Don't comment it out, remove it if it's necessary.

  7. 
      
tsoome
  1. 
      
  2. usr/src/lib/Makefile (Diff revision 24)
     
     

    yes, libumem, thanks.

  3. 
      
tsoome
richlowe
  1. Ship It!
  2. 
      
andy_js
  1. If Rich is happy with the mapfile (the ILLUMOSprivate thing) I'm happy with the integration.

  2. 
      
tsoome
tsoome
tsoome
tsoome
Review request changed

Status: Closed (submitted)

Loading...