-
-
usr/src/test/smbclient-tests/cmd/Makefile.cmd (Diff revision 1) Probably want $(POST_PROCESS_O) here.
-
usr/src/test/smbclient-tests/cmd/abort_conn/abort_conn.c (Diff revision 1) close can clobber the errno here.
-
usr/src/test/smbclient-tests/cmd/close_wr/close_wr.c (Diff revision 1) Looks like this file isn't cstyle clean.
-
-
-
usr/src/test/smbclient-tests/cmd/cp_mmap/cp_mmap.c (Diff revision 1) Should probably be unsigned values.
-
usr/src/test/smbclient-tests/cmd/cp_mmap/cp_mmap.c (Diff revision 1) Is there a reason we're not using getopt?
-
usr/src/test/smbclient-tests/cmd/cp_mmap/cp_mmap.c (Diff revision 1) Make explicit comparison or change to boolean_t?
-
usr/src/test/smbclient-tests/cmd/cp_mmap/cp_mmap.c (Diff revision 1) Is there something outside of the test that makes sure that the file we're passing in isn't a zero-byte file? Should we check that here?
-
usr/src/test/smbclient-tests/cmd/mkfile_mmap/mkfile_mmap.c (Diff revision 1) This program isn't cstyle clean
-
usr/src/test/smbclient-tests/cmd/mkfile_mmap/mkfile_mmap.c (Diff revision 1) Probably should be unsigned
-
usr/src/test/smbclient-tests/cmd/mkfile_mmap/mkfile_mmap.c (Diff revision 1) Is there a reason ew're not using getopt?
-
usr/src/test/smbclient-tests/cmd/mkfile_mmap/mkfile_mmap.c (Diff revision 1) May be worth using a form that we can actually check errors from. Maybe strtonum() now is the best since we don't care about the base.
-
usr/src/test/smbclient-tests/cmd/mkfile_mmap/mkfile_mmap.c (Diff revision 1) This is a bit ugly (imo)
-
-
-
usr/src/test/smbclient-tests/cmd/prot_mmap/prot_mmap.c (Diff revision 1) Should probably be unsigned
-
-
usr/src/test/smbclient-tests/cmd/prot_mmap/prot_mmap.c (Diff revision 1) What happens if both files are zero size? Should the test guard against that?
-
-
usr/src/test/smbclient-tests/cmd/rw_mmap/rw_mmap.c (Diff revision 1) Should be unsigned, we never want to go negative / overflow. I'd probably just make it a uint64_t
-
-
usr/src/test/smbclient-tests/cmd/rw_mmap/rw_mmap.c (Diff revision 1) Need to check for malloc failure.
-
usr/src/test/smbclient-tests/cmd/rw_mmap/rw_mmap.c (Diff revision 1) Don't we want to check the read return value before using it here? If this was -1, this would blow up in a hurry.
-
usr/src/test/smbclient-tests/cmd/rw_mmap/rw_mmap.c (Diff revision 1) Same return value checking note
-
-
usr/src/test/smbclient-tests/doc/README (Diff revision 1) A missing prerequiesite is making sure that expect or something else is installed.
-
usr/src/test/smbclient-tests/include/services_common.ksh (Diff revision 1) Clean up white space noise in the file?
-
usr/src/test/smbclient-tests/include/services_common.ksh (Diff revision 1) If we're using the -s option, why do we need to check the state with the timeout logic?
-
usr/src/test/smbclient-tests/include/services_common.ksh (Diff revision 1) If we're using the -s option, why do we need to check the state with the timeout logic?
-
usr/src/test/smbclient-tests/include/smbmount_common.ksh (Diff revision 1) Missing space between func and arg?
-
usr/src/test/smbclient-tests/include/smbmount_common.ksh (Diff revision 1) Can this all be replaced with the explicit mount options?
-
usr/src/test/smbclient-tests/include/smbutil_common.ksh (Diff revision 1) I think you just want pkill -u <pid> -x smbiod
-
usr/src/test/smbclient-tests/include/utils_common.ksh (Diff revision 1) Can we use modern tests, eg. '[['
-
usr/src/test/smbclient-tests/include/utils_common.ksh (Diff revision 1) Do you care if this ls/awk, etc fail?
-
-
-
usr/src/test/smbclient-tests/include/xattr_common.ksh (Diff revision 1) What if it's not a file, but it exists?
-
-
-
-
usr/src/test/smbclient-tests/tests/configure/configure.ksh (Diff revision 1) Is there a script that helps clean up these things if we ultimately fail while in test context so we can run again?
Perhaps we can add a note about potential system side effects to the README?
-
-
-
-
-
usr/src/test/smbclient-tests/tests/nsmbrc/tp_nsmbrc_003.ksh (Diff revision 1) Check return values / empty results?
-
usr/src/test/smbclient-tests/tests/nsmbrc/tp_nsmbrc_004.ksh (Diff revision 1) Check return values / empty results?
-
usr/src/test/smbclient-tests/tests/nsmbrc/tp_nsmbrc_005.ksh (Diff revision 1) Check return values / empty results?
-
usr/src/test/smbclient-tests/tests/nsmbrc/tp_nsmbrc_006.ksh (Diff revision 1) Check return values / empty results?
-
usr/src/test/smbclient-tests/tests/smbfs/mmap/tp_mmap_001.ksh (Diff revision 1) There's no copyright holder here? Can we maybe use the new cddl header for the tp_mmap_*.ksh tests?
-
usr/src/test/smbclient-tests/tests/smbfs/mmap/tp_mmap_005.ksh (Diff revision 1) Trim trailing whitespace in this file?
-
usr/src/test/smbclient-tests/tests/smbfs/mmap/tp_mmap_009.ksh (Diff revision 1) Can we at least make sure we have 80 columns in comments please?
-
usr/src/test/test-runner/stf/contrib/include/ctiutils.shlib (Diff revision 1) This probably needs to be dealt with as a THIRDPARTYLICENE and a THIRDPARTYLICENSE.descrip that is also mentioned in the package manifest.
-
usr/src/test/test-runner/stf/contrib/include/ctiutils.shlib (Diff revision 1) Any background on this XXX?
-
usr/src/test/test-runner/stf/contrib/include/ctiutils.shlib (Diff revision 1) If we're always going to do it, let's just remove the conditional.
-
usr/src/test/test-runner/stf/contrib/include/ctiutils.shlib (Diff revision 1) a heredoc may be easier to use here
7519 Add smbclient tests
Review Request #916 — Created Feb. 24, 2018 and submitted
Information | |
---|---|
gwr | |
illumos-gate | |
7519 | |
Reviewers | |
general | |
7519 Add smbclient tests
Import the SMB client test from the old STC collection.
Port those tests to STF.
Add Jilin's mmap tests.
Lots of cleanup.
Ran the new tests. Below is some sample output from the new tests.
Note that the 'SKIP' status is for tests that would do thing that
may take a long time (i.e. copying very large files) and the "-f"
option to smbclienttest tells it to skip those tests.admin@oi-test:/tmp$ /opt/smbclient-tests/bin/smbclienttest -f -s orion Test: /opt/smbclient-tests/tests/nsmbrc/tp_nsmbrc_001 (run as admin) [00:01] [PASS] Test: /opt/smbclient-tests/tests/nsmbrc/tp_nsmbrc_002 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/nsmbrc/tp_nsmbrc_003 (run as admin) [00:01] [FAIL] Test: /opt/smbclient-tests/tests/nsmbrc/tp_nsmbrc_004 (run as admin) [00:01] [PASS] Test: /opt/smbclient-tests/tests/nsmbrc/tp_nsmbrc_005 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/nsmbrc/tp_nsmbrc_006 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/sharectl/tp_sharectl_001 (run as root) [00:00] [PASS] Test: /opt/smbclient-tests/tests/sharectl/tp_sharectl_002 (run as root) [00:00] [PASS] Test: /opt/smbclient-tests/tests/sharectl/tp_sharectl_003 (run as root) [00:01] [PASS] Test: /opt/smbclient-tests/tests/sharectl/tp_sharectl_004 (run as root) [00:01] [PASS] Test: /opt/smbclient-tests/tests/sharectl/tp_sharectl_005 (run as root) [00:00] [PASS] Test: /opt/smbclient-tests/tests/sharectl/tp_sharectl_006 (run as root) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/acl/tp_acl_001 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/acl/tp_acl_002 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/acl/tp_acl_003 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/acl/tp_acl_004 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/acl/tp_acl_005 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/cptest/tp_cptest_001 (run as admin) [00:01] [PASS] Test: /opt/smbclient-tests/tests/smbfs/cptest/tp_cptest_002 (run as admin) [00:04] [PASS] Test: /opt/smbclient-tests/tests/smbfs/cptest/tp_cptest_003 (run as admin) [00:00] [SKIP] Test: /opt/smbclient-tests/tests/smbfs/cptest/tp_cptest_004 (run as admin) [00:00] [SKIP] Test: /opt/smbclient-tests/tests/smbfs/cptest/tp_cptest_005 (run as admin) [00:01] [PASS] Test: /opt/smbclient-tests/tests/smbfs/cptest/tp_cptest_006 (run as admin) [00:00] [SKIP] Test: /opt/smbclient-tests/tests/smbfs/cptest/tp_cptest_007 (run as admin) [00:00] [SKIP] Test: /opt/smbclient-tests/tests/smbfs/cptest/tp_cptest_008 (run as admin) [00:00] [SKIP] Test: /opt/smbclient-tests/tests/smbfs/cptest/tp_cptest_009 (run as admin) [00:00] [SKIP] Test: /opt/smbclient-tests/tests/smbfs/create/tp_create_001 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/create/tp_create_002 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/create/tp_create_003 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/create/tp_create_004 (run as admin) [00:01] [PASS] Test: /opt/smbclient-tests/tests/smbfs/create/tp_create_005 (run as admin) [00:01] [PASS] Test: /opt/smbclient-tests/tests/smbfs/create/tp_create_006 (run as admin) [00:01] [PASS] Test: /opt/smbclient-tests/tests/smbfs/create/tp_create_007 (run as admin) [00:03] [PASS] Test: /opt/smbclient-tests/tests/smbfs/create/tp_create_008 (run as admin) [00:00] [SKIP] Test: /opt/smbclient-tests/tests/smbfs/create/tp_create_009 (run as admin) [00:00] [SKIP] Test: /opt/smbclient-tests/tests/smbfs/create/tp_create_010 (run as admin) [00:00] [SKIP] Test: /opt/smbclient-tests/tests/smbfs/create/tp_create_011 (run as admin) [00:00] [SKIP] Test: /opt/smbclient-tests/tests/smbfs/create/tp_create_012 (run as admin) [00:00] [SKIP] Test: /opt/smbclient-tests/tests/smbfs/error/tp_error_001 (run as admin) [00:02] [PASS] Test: /opt/smbclient-tests/tests/smbfs/error/tp_error_002 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/misc/tp_misc_001 (run as admin) [00:04] [PASS] Test: /opt/smbclient-tests/tests/smbfs/misc/tp_misc_002 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/misc/tp_misc_003 (run as admin) [00:04] [PASS] Test: /opt/smbclient-tests/tests/smbfs/mkdir/tp_mkdir_001 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/mkdir/tp_mkdir_002 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/mkdir/tp_mkdir_003 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/mkdir/tp_mkdir_004 (run as admin) [00:30] [PASS] Test: /opt/smbclient-tests/tests/smbfs/mkdir/tp_mkdir_005 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/mkdir/tp_mkdir_006 (run as admin) [00:01] [PASS] Test: /opt/smbclient-tests/tests/smbfs/mmap/tp_mmap_001 (run as admin) [00:02] [PASS] Test: /opt/smbclient-tests/tests/smbfs/mmap/tp_mmap_002 (run as admin) [00:03] [PASS] Test: /opt/smbclient-tests/tests/smbfs/mmap/tp_mmap_003 (run as admin) [00:02] [PASS] Test: /opt/smbclient-tests/tests/smbfs/mmap/tp_mmap_004 (run as admin) [00:03] [PASS] Test: /opt/smbclient-tests/tests/smbfs/mmap/tp_mmap_005 (run as admin) [00:01] [PASS] Test: /opt/smbclient-tests/tests/smbfs/mmap/tp_mmap_006 (run as admin) [00:03] [PASS] Test: /opt/smbclient-tests/tests/smbfs/mmap/tp_mmap_007 (run as admin) [00:04] [PASS] Test: /opt/smbclient-tests/tests/smbfs/mmap/tp_mmap_008 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/mmap/tp_mmap_009 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/mmap/tp_mmap_010 (run as admin) [00:02] [PASS] Test: /opt/smbclient-tests/tests/smbfs/mvtest/tp_mvtest_001 (run as admin) [00:01] [PASS] Test: /opt/smbclient-tests/tests/smbfs/mvtest/tp_mvtest_002 (run as admin) [00:04] [PASS] Test: /opt/smbclient-tests/tests/smbfs/mvtest/tp_mvtest_003 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/mvtest/tp_mvtest_004 (run as admin) [00:00] [SKIP] Test: /opt/smbclient-tests/tests/smbfs/mvtest/tp_mvtest_005 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/mvtest/tp_mvtest_006 (run as admin) [00:03] [PASS] Test: /opt/smbclient-tests/tests/smbfs/mvtest/tp_mvtest_007 (run as admin) [00:08] [PASS] Test: /opt/smbclient-tests/tests/smbfs/xattr/tp_xattr_001 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/xattr/tp_xattr_002 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/xattr/tp_xattr_003 (run as admin) [00:00] [SKIP] Test: /opt/smbclient-tests/tests/smbfs/xattr/tp_xattr_004 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/xattr/tp_xattr_005 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/xattr/tp_xattr_006 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/xattr/tp_xattr_007 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbfs/xattr/tp_xattr_008 (run as admin) [00:04] [PASS] Test: /opt/smbclient-tests/tests/smbfs/xattr/tp_xattr_009 (run as admin) [00:20] [PASS] Test: /opt/smbclient-tests/tests/smbmount/tp_smbmount_001 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbmount/tp_smbmount_002 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbmount/tp_smbmount_003 (run as admin) [00:01] [PASS] Test: /opt/smbclient-tests/tests/smbmount/tp_smbmount_004 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbmount/tp_smbmount_005 (run as admin) [00:02] [PASS] Test: /opt/smbclient-tests/tests/smbmount/tp_smbmount_006 (run as admin) [00:01] [PASS] Test: /opt/smbclient-tests/tests/smbmount/tp_smbmount_007 (run as admin) [00:00] [SKIP] Test: /opt/smbclient-tests/tests/smbmount/tp_smbmount_008 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbmount/tp_smbmount_009 (run as admin) [00:01] [PASS] Test: /opt/smbclient-tests/tests/smbmount/tp_smbmount_010 (run as admin) [00:02] [PASS] Test: /opt/smbclient-tests/tests/smbmount/tp_smbmount_011 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbmount/tp_smbmount_012 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbmount/tp_smbmount_013 (run as admin) [00:00] [SKIP] Test: /opt/smbclient-tests/tests/smbmount/tp_smbmount_014 (run as admin) [00:00] [SKIP] Test: /opt/smbclient-tests/tests/smbmount/tp_smbmount_015 (run as admin) [00:00] [SKIP] Test: /opt/smbclient-tests/tests/smbmount/tp_smbmount_016 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbutil/tp_smbutil_001 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbutil/tp_smbutil_002 (run as admin) [00:02] [SKIP] Test: /opt/smbclient-tests/tests/smbutil/tp_smbutil_003 (run as admin) [00:02] [PASS] Test: /opt/smbclient-tests/tests/smbutil/tp_smbutil_004 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbutil/tp_smbutil_005 (run as admin) [00:03] [PASS] Test: /opt/smbclient-tests/tests/smbutil/tp_smbutil_006 (run as admin) [00:05] [PASS] Test: /opt/smbclient-tests/tests/smbutil/tp_smbutil_007 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbutil/tp_smbutil_008 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbutil/tp_smbutil_009 (run as admin) [00:00] [SKIP] Test: /opt/smbclient-tests/tests/smbutil/tp_smbutil_010 (run as admin) [00:00] [SKIP] Test: /opt/smbclient-tests/tests/smbutil/tp_smbutil_011 (run as admin) [00:01] [PASS] Test: /opt/smbclient-tests/tests/smbutil/tp_smbutil_012 (run as admin) [00:00] [PASS] Test: /opt/smbclient-tests/tests/smbutil/tp_smbutil_013 (run as admin) [00:05] [PASS] Test: /opt/smbclient-tests/tests/smbutil/tp_smbutil_014 (run as admin) [00:04] [PASS] Test: /opt/smbclient-tests/tests/smbutil/tp_smbutil_015 (run as admin) [00:50] [PASS] Test: /opt/smbclient-tests/tests/smbutil/tp_smbutil_016 (run as admin) [00:04] [PASS](there was one transient failure because this was a somewhat slow VM)
Change Summary:
Deliver a license for ctituils.shlib
Description: |
|
---|
Change Summary:
Major update. This is the version we're using internaly now.
I hope we handled all the review feedback given previously.
Description: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 3 (+17440 -2)
|
Change Summary:
Fix space-tab sequences
Diff: |
Revision 4 (+17440 -2)
|
---|
Change Summary:
more ctyle etc
Diff: |
Revision 5 (+17438 -2)
|
---|
Change Summary:
more cstyle
Diff: |
Revision 6 (+17438 -2)
|
---|
-
Thanks for all the clean up here. I'm generally happy with how things changed here. I appreciate all the work that went into this.
-
usr/src/test/smbclient-tests/include/smbmount_common.ksh (Diff revisions 1 - 6) Is there a reason this now requires sudo?
-
usr/src/test/smbclient-tests/tests/smbfs/acl/tp_acl_005.ksh (Diff revisions 1 - 6) Another case where it seems sudo is now required?
-
usr/src/test/smbclient-tests/tests/smbfs/xattr/tp_xattr_009.ksh (Diff revisions 1 - 6) Could be $PWD, but doesn't matter.
Change Summary:
Latest version of this, as shown on https://github.com/illumos/illumos-gate/pull/37/files
Diff: |
Revision 7 (+17449 -2)
|
---|
Change Summary:
Fix missing manifest entry, remove unused shell variable
I think this is RTI ready.
Diff: |
Revision 8 (+17449 -2)
|
---|