5404 smbfs needs mmap support

Review Request #915 - Created Feb. 24, 2018 and submitted

Information
Gordon Ross
illumos-gate
5404
Reviewers
general

5404 smbfs needs mmap support

This is (mostly) work from Jilin Xpd jilinxpd@gmail.com
done during the 2012 Google Summer of Code program.
I finished it up, did some debug and testing etc.
Along the way, I tried to make it "closer" to the
NFS code from which this was derived.

Latest version is on github here:
https://github.com/gwr/illumos-gate/tree/smbcl-mmap5b

Compile things in an smbfs mount (the linker is among the long list of
evil tools that don't have a fall-back when mmap(2) is unsupported).
There are also some STC-derived tests coming (see other review).

wr@oi-test:/$ SRV=orion opt/smbclient-tests/bin/smbclienttest -c opt/smbclient-tests/runfiles/just-mmap.run 
Test: /opt/smbclient-tests/tests/smbfs/mmap/tp_mmap_001 (run as root) [00:19] [PASS]
Test: /opt/smbclient-tests/tests/smbfs/mmap/tp_mmap_002 (run as root) [00:29] [PASS]
Test: /opt/smbclient-tests/tests/smbfs/mmap/tp_mmap_003 (run as root) [00:41] [PASS]
Test: /opt/smbclient-tests/tests/smbfs/mmap/tp_mmap_004 (run as root) [00:42] [PASS]
Test: /opt/smbclient-tests/tests/smbfs/mmap/tp_mmap_005 (run as root) [00:12] [PASS]
Test: /opt/smbclient-tests/tests/smbfs/mmap/tp_mmap_006 (run as root) [00:10] [PASS]
Test: /opt/smbclient-tests/tests/smbfs/mmap/tp_mmap_007 (run as root) [00:07] [PASS]
Test: /opt/smbclient-tests/tests/smbfs/mmap/tp_mmap_008 (run as root) [00:02] [PASS]
Test: /opt/smbclient-tests/tests/smbfs/mmap/tp_mmap_009 (run as root) [00:02] [PASS]
Test: /opt/smbclient-tests/tests/smbfs/mmap/tp_mmap_010 (run as root) [00:52] [PASS]

Results Summary
PASS      10

Running Time:   00:03:40
Percent passed: 100.0%

Issues

  • 0
  • 10
  • 3
  • 13
Description From Last Updated
C Fraire
Jason King
C Fraire
C Fraire
C Fraire
Toomas Soome
Jason King
Toomas Soome
Jason King
Andrew Stormont
Gordon Ross
Gordon Ross
Gordon Ross
Review request changed

Status: Closed (submitted)

Loading...