9180 gss_mechs/mech_krb5: this statement may fall through
Review Request #907 — Created Feb. 22, 2018 and submitted
| Information | |
|---|---|
| tsoome | |
| illumos-gate | |
| 9180 | |
| 4659b33... | |
| Reviewers | |
| general | |
/code/illumos-gate/usr/src/uts/common/gssapi/mechs/krb5/krb5/krb/unparse.c:131:9: error: this statement may fall through [-Werror=implicit-fallthrough=]
if (no_realm) {
^
/code/illumos-gate/usr/src/uts/common/gssapi/mechs/krb5/krb5/krb/unparse.c:136:2: note: here
case COMPONENT_SEP:
^~~~
/code/illumos-gate/usr/src/uts/common/gssapi/mechs/krb5/mech/k5unseal.c:501:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
code = memcmp(md5cksum.contents, ptr+14, 8);
~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/code/illumos-gate/usr/src/uts/common/gssapi/mechs/krb5/mech/k5unseal.c:504:5: note: here
default:
^~~~~~~
../krb5/krb/chpw.c:549:17: error: this statement may fall through [-Werror=implicit-fallthrough=]
*code_string = "Success";
~~~~~~~~~~~~~^~~~~~~~~~~
../krb5/krb/chpw.c:550:4: note: here
default:
^~~~~~~
cc1: all warnings being treated as errors
Change Summary:
Nuked broken case body.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+3 -72) |