9178 sasl_plugins: this statement may fall through

Review Request #905 — Created Feb. 22, 2018 and submitted

tsoome
illumos-gate
9178
db79f96...
general
../digestmd5.c:5067:5: error: this statement may fall through [-Werror=implicit-fallthrough=]
  if (!serverin) {
     ^
../digestmd5.c:5095:5: note: here
     case 3:
     ^~~~
../digestmd5.c:5123:16: error: this statement may fall through [-Werror=implicit-fallthrough=]
  ctext->cipher = NULL;
../digestmd5.c:5125:5: note: here
     case 2:
     ^~~~

../login.c:130:5: error: this statement may fall through [-Werror=implicit-fallthrough=]
  if (clientinlen == 0) {
     ^
../login.c:140:5: note: here
     case 2:
     ^~~~

cc1: all warnings being treated as errors


citrus
  1. It's always helpful when there are already comments indicating that fall-through is the desired behaviour!

  2. 
      
hans
  1. 
      
  2. usr/src/lib/sasl_plugins/login/login.c (Diff revision 1)
     
     
    Is there a reason you're not fixing this trailing whitespace as well?
  3. 
      
tsoome
hans
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...