9148 sun_sas: this statement may fall through

Review Request #881 — Created Feb. 20, 2018 and submitted

tsoome
illumos-gate
9148
1aade43...
general
../common/sun_sas.c:278:5: error: this statement may fall through [-Werror=implicit-fallthrough=]
     log(LOG_DEBUG, ROUTINE,
     ^~~~~~~~~~~~~~~~~~~~~~~
         "Lock failed: not recoverable 0x%x", mp);
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../common/sun_sas.c:280:4: note: here
    default:
    ^~~~~~~
cc1: all warnings being treated as errors


  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
seeemef@mac.com
  1. Ship It!
  2. 
      
citrus
  1. 
      
  2. usr/src/lib/sun_sas/common/sun_sas.c (Diff revision 1)
     
     

    Are you sure this should not be a break?
    Looking at the previous case statements, they all just log and break for an unrecoverable error.

    1. It seems you are right there.

  3. 
      
tsoome
citrus
  1. Ship It!
  2. 
      
seeemef@mac.com
  1. Got it. LGTM.

  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...