9135 libresolv2: this statement may fall through

Review Request #871 — Created Feb. 19, 2018 and submitted

tsoome
illumos-gate
9135
1f7f35b...
general
../common/nameser/ns_print.c: In function '__ns_sprintrrf':
../common/nameser/ns_print.c:864:19: error: this statement may fall through [-Werror=implicit-fallthrough=]
  case ns_t_dhcid: {
                   ^
../common/nameser/ns_print.c:899:2: note: here
  case ns_t_ipseckey: {
  ^~~~
../common/nameser/ns_print.c:899:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
  case ns_t_ipseckey: {
                      ^
../common/nameser/ns_print.c:990:2: note: here
  case ns_t_hip: {
  ^~~~

../common/nameser/ns_ttl.c: In function '__ns_parse_ttl':
../common/nameser/ns_ttl.c:113:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
   case 'W':  tmp *= 7;
              ~~~~^~~~
../common/nameser/ns_ttl.c:114:3: note: here
   case 'D':  tmp *= 24;
   ^~~~
../common/nameser/ns_ttl.c:114:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
   case 'D':  tmp *= 24;
              ~~~~^~~~~
../common/nameser/ns_ttl.c:115:3: note: here
   case 'H':  tmp *= 60;
   ^~~~
../common/nameser/ns_ttl.c:115:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
   case 'H':  tmp *= 60;
              ~~~~^~~~~
../common/nameser/ns_ttl.c:116:3: note: here
   case 'M':  tmp *= 60;
   ^~~~

cc1: all warnings being treated as errors


  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
citrus
  1. 
      
  2. This one falls through too. Strange that is doesn't appear in the gcc output.

  3. 
      
tsoome
citrus
  1. Ship It!
  2. 
      
alp
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...