9114 cmd/audio: invalid conversion from 'char' to 'char*'
Review Request #861 — Created Feb. 15, 2018 and submitted
Information | |
---|---|
tsoome | |
illumos-gate | |
9114 | |
086de6e... | |
Reviewers | |
general | |
In file included from AudioLib.cc:29:0: ../include/Audio.h:89:18: error: invalid conversion from 'char' to 'char*' [-fpermissive] char *msg = '\0') const; // error message ^~~~ *** Error code 1 dmake: Warning: Command failed for target `AudioLib.o'
Change Summary:
we also need to check for NULL before going for printf.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+4 -5) |
-
-
usr/src/cmd/audio/utilities/AudioDebug.cc (Diff revision 2) Maybe this should be the string, "unknown error"? Maybe make str const since we don't modify it?
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+5 -11) |
Change Summary:
trivial cstyle fixes.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+5 -13) |