9090 ses: using integer constants in boolean context, the expression will always evaluate to 'true'
Review Request #856 — Created Feb. 10, 2018 and submitted
In file included from ../../common/io/scsi/targets/ses.c:35:0:
../../common/io/scsi/targets/ses.c: In function 'ses_callback':
../../common/io/scsi/targets/ses.c:1329:37: error: ?: using integer constants in boolean context, the expression will always evaluate to 'true' [-Werror=int-in-bool-context]
(err == EBUSY)? SES_BUSY_TIME: SES_RESTART_TIME,
../../common/sys/scsi/targets/ses.h:252:7: note: in definition of macro 'SES_ENABLE_RESTART'
(ms_time)? (drv_usectohz(ms_time * 1000)) : \
cc1: all warnings being treated as errors
Looking at the code I think it's actually the SES_ENABLE_RESTART macro that needs to be fixed. This seems to just skirt around the issue.