6653 dtrace modifies ELF string table causing problems for linker

Review Request #853 — Created Feb. 10, 2018 and submitted Feb. 10, 2018, 9:19 p.m.

Information
Owner:	citrus
Repository:	illumos-gate
Branch:	master
Bugs:
Depends On:
Commit:	ac9c5be...
Reviewers
Groups:	general
People:

Description

6653 dtrace modifies ELF string table causing problems for linker

Testing Done

cherry-picking this dtrace fix from joyent where it has been for a year now; see:

https://smartos.org/bugview/OS-5946

This has also been in OmniOS for a month and allowed us to upgrade past binutils 2.25.1

There's more information in the issue https://illumos.org/issues/6653

Issues

0
0
1
0
All Issues: 1

Description	From	Last Updated
I think something like "probe name too long" might be more helpful here.	andy_js	Feb. 10, 2018, 10:05 a.m.

So the problem is like "writing to constant strings"?

citrus Feb. 10, 2018, 9:59 a.m.

Yes, and became (more of?) a problem with later binutils as they introduced string suffix merging for ELF .strtab.
(see https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=ef10c3ace00674e8c3599c3bf95f06c87d68898b for their commit)

With this change, an entry in .strtab like "resource__free" would also be used for "free" however dtrace was replacing the "__" with "-" so that the second string now pointed to "ree"

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

usr/src/lib/libdtrace/common/dt_link.c (Diff revision 1)

Show all issues

I think something like "probe name too long" might be more helpful here.

Change Summary:

modify error message

Commit:

-	0b3b148a9092f678c256b48392271c040e6a0b42
+	ac9c5bef86a94d2cdbe87b3c411dfc2de6b43bff

Diff:

Revision 2 (+12 -6)

Show changes

usr/src/lib/libdtrace/common/dt_link.c

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 3.0.18

6653 dtrace modifies ELF string table causing problems for linker

Change Summary:

Commit:

Diff:

Status: Closed (submitted)