8925 boot1.efi: link with libefi

Review Request #802 — Created Dec. 16, 2017 and submitted

tsoome
illumos-gate
8925
2d2c212...
general
https://svnweb.freebsd.org/base?view=revision&revision=322932
https://svnweb.freebsd.org/base?view=revision&revision=322938


seeemef@mac.com
  1. This LGTM too.

  2. 
      
jbk
  1. Ship It!
  2. 
      
tsoome
seeemef@mac.com
  1. 
      
  2. usr/src/boot/sys/boot/efi/Makefile (Diff revision 2)
     
     

    Hi. With order now being significant, should the boot1 and/or loader targets be defined below as explicitly dependent on the libefi target?

    1. Yes, thats good find, fixed.

  3. 
      
tsoome
yuripv
  1. 
      
  2. usr/src/boot/sys/boot/efi/Makefile (Diff revision 3)
     
     

    Or you could use .WAIT here to make it even more visible.

    1. the .WAIT there does not help make because it (.WAIT) is only about dependency ordering and here we do set value for variable.

    2. hint: you have all ...: $(SUBDIRS) rule.

    3. Yep, but when i did add .WAIT and did remove the added dependencies, and nope, make did not check libefi first...

    4. OK, sorry for the noise.

  3. 
      
yuripv
  1. Ship It!
  2. 
      
seeemef@mac.com
  1. LGTM

  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...