-
-
usr/src/uts/common/fs/xattr.c (Diff revision 1) A comment here would be nice. Maybe:
Note: gfs_dir_inactive returns NULL when we've
lost a race with VGET (node is still active)
otherwise this is really the last ref.
8806 xattr_dir_inactive() releases used vnode with kernel panic
Review Request #789 — Created Dec. 4, 2017 and submitted
Information | |
---|---|
vgusev | |
illumos-gate | |
master | |
8806 | |
3ae7d8f... | |
Reviewers | |
general | |
gwr |
8806 xattr_dir_inactive() releases used vnode with kernel panic
Testing for 12+ hours based on reproducer at #8806, no crashes.
Change Summary:
Added "/ vp was freed /" comment.
Commit: |
|
||
---|---|---|---|
Diff: |
Revision 2 (+8 -15) |
-
-
-
usr/src/uts/common/fs/xattr.c (Diff revision 2) I'm not very happy with this typecast, but explicit
dp->xattr_gfs_private.gfsd_file.gfs_size
would be harder to read (but I still prefer it).
-
-
usr/src/uts/common/fs/xattr.c (Diff revision 2) Please let me leave as is because original code is:
kmem_free(fp, fp->gfs_size);
gfs_size should be used here, not direct size because gfs_size is set in gfs layer and in xattr layer it could be different.