8801 loader: always issue our dhcp request

Review Request #783 — Created Nov. 29, 2017 and submitted

tsoome
illumos-gate
8801
787
601d55c...
general
https://svnweb.freebsd.org/base?view=revision&revision=318990

While it sounds like a good idea to extract the RFC1048 data from PXE, in the
end it is not and it is causing lots of issues.  Our pxeloader might need
options which are incompatible with other pxe servers (for example iPXE, but
not only).

Our pxe loaders are also now settings their own user class, so it is useful to
issue our own pxe request at startup


ptribble
  1. I'm confused. The synopsis talks about dhcp, the description talks about PXE, the code being changed is bootp. I suspect the bug report needs a bit of clarification.

    Maybe the comment above the removed block of code needs to be updated if the logic is being changed.

    Also, is dhcp_try_rfc1048 used anywhere else (if not, could it be removed))?

    1. Oh indeed the comments are mixing bootp/dhcp/pxe there, as the original bootp() was once extended to support dhcp (and pxe usually does get its network configuration via dhcp, but is not just about dhcp). Also indeed, we can just remove dhcp_try_rfc1048() now.

    2. Obviously the comments are not been touched for quite some time and the terms like PXE, BOOTP and DHCP are used quite freely... the bootp/dhcp code really is shared and the common method for PXE boot is to fetch the network configuration by using dhcp (and providing pxe related identifiers).

  2. 
      
tsoome
tsoome
ptribble
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...