8844 libdns_sd: variable set but not used

Review Request #770 — Created Nov. 21, 2017 and submitted

tsoome
illumos-gate
8844
c623ff6...
general
../common/dnssd_clientstub.c: In function 'FreeDNSServiceOp':
../common/dnssd_clientstub.c:411:30: error: variable 'op_were_not_going_to_free_but_we_need_to_fool_the_analyzer' set but not used [-Werror=unused-but-set-variable]
         static DNSServiceOp *op_were_not_going_to_free_but_we_need_to_fool_the_analyzer;
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors


yuripv
  1. As it's something we (you) are syncing with upstream, may be just silence in the Makefile?

    1. I'm inclined to agree.

  2. 
      
tsoome
jgmills
  1. You could make it more specific by adding this line to Makefile.com instead of the one you have now:
    
    pics/dnssd_clientstub.o    := CERRWARN += -_gcc=-Wno-unused-but-set-variable
  2. 
      
tsoome
andy_js
  1. Ship It!
  2. 
      
jgmills
  1. Looks good to me.

  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...