8840 libtnfctl: variable 'ret_pp' set but not used

Review Request #766 — Created Nov. 21, 2017 and submitted

tsoome
illumos-gate
8840
93e0ce1...
general
../comb.c:509:15: error: variable 'ret_pp' set but not used [-Werror=unused-but-set-variable]
  comb_key_t **ret_pp;
               ^~~~~~
cc1: all warnings being treated as errors


tsoome
yuripv
  1. Seeing several issues involving assert(), I wonder if we can "fix" it instead (even for NDEBUG)?

    1. I think it could be done via inlining, same way I did address FEESZ() in https://www.illumos.org/rb/r/749/

      The problem is that with macros, the macro expansion will happen before the compiler has chance to do anything, and we end up without the code which would otherwise "use" those variables. inlining function would allow the compiler to do its thing with analyzes and optimize out the unneeded bits.

      I think the assert would need separate patch and work however.

  2. 
      
yuripv
  1. Ship It!
  2. 
      
andy_js
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...