8823 print: variable 'error' set but not used

Review Request #750 — Created Nov. 20, 2017 and submitted

tsoome
illumos-gate
8823
a6633aa...
general
../common/psm.c: In function 'psm_sym':
../common/psm.c:82:8: error: variable 'error' set but not used [-Werror=unused-but-set-variable]
  char *error = "invalid input";
        ^~~~~
cc1: all warnings being treated as errors


yuripv
  1. Ship It!
  2. 
      
jgmills
  1. I'm disturbed by the newly-introduced `return (func)' line.  Maybe it should be `return (NULL)' instead.  Otherwise, your changes seem fine to me.
    1. I felt the return there is better than empty statement (;) and fallthrough.

  2. 
      
tsoome
jgmills
  1. Looks good to me.

  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...