8786 s1394: variable 'type' set but not used

Review Request #725 — Created Nov. 7, 2017 and submitted

tsoome
illumos-gate
8786
7c7ae1c...
general
../../common/io/1394/s1394_hotplug.c:146:11: error: variable 'type' set but not used [-Werror=unused-but-set-variable]
  uint32_t type, key, value;
           ^~~~
cc1: all warnings being treated as errors


tsoome
andy_js
  1. Ship It!
  2. 
      
rm
  1. Ship It!
  2. 
      
jgmills
  1. The real problem is that the CFGROM_TYPE_KEY_VALUE macro sets its last three parameters, even though some of them may not be used in the code itself.  Marking the type variable as possibly unused is probably the best solution for this particular file.
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...