8766 pcitool: typedef locally defined but not used

Review Request #706 — Created Nov. 6, 2017 and submitted

tsoome
illumos-gate
8766
4be7387...
general
../pcitool_ui.c: In function 'parse_nexus_opts':
../pcitool_ui.c:904:4: error: typedef 'nexus_opts_index_t' locally defined but not used [-Werror=unused-local-typedefs]
  } nexus_opts_index_t;
    ^~~~~~~~~~~~~~~~~~
../pcitool_ui.c: In function 'parse_device_opts':
../pcitool_ui.c:1076:4: error: typedef 'bdf_opts_index_t' locally defined but not used [-Werror=unused-local-typedefs]
  } bdf_opts_index_t;
    ^~~~~~~~~~~~~~~~
../pcitool_ui.c: In function 'parse_probeone_opts':
../pcitool_ui.c:1444:4: error: typedef 'p1_bdf_opts_index_t' locally defined but not used [-Werror=unused-local-typedefs]
  } p1_bdf_opts_index_t;
    ^~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
*** Error code 1
dmake: Fatal error: Command failed for target `pcitool_ui.o'


andy_js
  1. Why was this chosen over removing the typedef from those enums?

    1. A bit of overthinking:)

  2. 
      
tsoome
seeemef@mac.com
  1. LGTM

  2. 
      
jbk
  1. Ship It!
  2. 
      
yuripv
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...