8749 loader: efipart_strategy is using wrong offset with >512B sectors

Review Request #691 — Created Oct. 31, 2017 and submitted

tsoome
illumos-gate
8749
87f1d94...
general
The strategy() calls are assuming 512B sectors, so we need to adjust the
offset accordingly.

https://reviews.freebsd.org/D12849

UEFI boot to verify 512B and 4k disks and zfs pools.

  • 0
  • 0
  • 0
  • 1
  • 1
Description From Last Updated
rm
  1. 
      
  2. Is there any concern for overflow in all this?
    1. I do not think so, because d_offset is coming from partition table, and therefore we should have sector number consistent with disk size. Of course we might ask if or how much we should trust in partition table itself (note the GPT is CRC32 checksummed). But if the table entry is wrong, we will read wrong data, and in case of zfs, it will mostly mean at least checksum error anyhow - so we will end up in error one way or another.

  3. 
      
tsoome
rm
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...