6026 Zero-padded IP address strings returned by SMB server...

Review Request #68 — Created June 22, 2015 and submitted

gwr
illumos-gate
6026
general

6026 Zero-padded IP address strings returned by SMB server...



  • 1
  • 0
  • 0
  • 0
  • 1
Description From Last Updated
Fixed. gwr gwr
marcel
  1. 
      
  2. usr/src/common/smbsrv/smb_inet.c (Diff revision 1)
     
     
    Why we do not fix this directly in inet_ntop.c?
    1. It's a matter of time. We need this to work in the SMB server before the change to inet_ntop gets rolled out.
      There's already a separate bug for inet_ntop: https://www.illumos.org/issues/5980
      We can add a note there to take this work-around out if/when 5980 gets fixed.

    2. Thanks for the explanation. The note is great idea. Maybe you should also add a reference to 5980 directly into smb_inet.c.

    3. I agree with Marcel -- mention 5980 by name in the comment.

  3. 
      
gwr
  1. 
      
  2. usr/src/common/smbsrv/smb_inet.c (Diff revision 1)
     
     
  3. 
      
gwr
Review request changed

Status: Closed (submitted)

Loading...