8721 libwrap is missing global symbol `resident`

Review Request #678 — Created Oct. 16, 2017 and submitted

wiedi
illumos-gate
general

The current version of Dante (http://www.inet.no/dante/) fails to build with the following error:

Undefined            first referenced
 symbol                  in file
resident                            sockd_child.o
ld: fatal: symbol referencing errors. No output written to sockd
collect2: error: ld returned 1 exit status

The reason seems to be that extern int resident; is declared in tcpd.h but the mapfile is missing it in the global section.

Booted into a system with this change and confirmed that building dante now works.

tsoome
  1. Ship It!
  2. 
      
rm
  1. I think that this looks good. It may be worth checking with Rich to see if we should include size information on this since it's a global variable as opposed to a function.

    1. As I understand it, we provide the size for filter symbols only (those that aren't a function, yes).

      What's likely is missing here is the NODIRECT flag, as e.g. usr/src/cmd/tcpd/tcpdchk.c provides its own resident symbol.

  2. 
      
wiedi
yuripv
  1. Ship It!
  2. 
      
tsoome
  1. Ship It!
  2. 
      
wiedi
Review request changed

Status: Closed (submitted)

Loading...