8721 libwrap is missing global symbol `resident`
Review Request #678 — Created Oct. 16, 2017 and submitted
Information | |
---|---|
wiedi | |
illumos-gate | |
Reviewers | |
general | |
The current version of Dante (http://www.inet.no/dante/) fails to build with the following error:
Undefined first referenced symbol in file resident sockd_child.o ld: fatal: symbol referencing errors. No output written to sockd collect2: error: ld returned 1 exit statusThe reason seems to be that
extern int resident;
is declared intcpd.h
but the mapfile is missing it in the global section.
Booted into a system with this change and confirmed that building dante now works.
-
I think that this looks good. It may be worth checking with Rich to see if we should include size information on this since it's a global variable as opposed to a function.