8686 loader.efi: replace comconsole_speed with ttya-mode

Review Request #665 — Created Sept. 26, 2017 and submitted

tsoome
illumos-gate
8686
e22b591...
general
8686 loader.efi: replace comconsole_speed with ttya-mode


  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
seeemef@mac.com
  1. 
      
  2. usr/src/boot/sys/boot/efi/loader/main.c (Diff revision 1)
     
     
    Perhaps reduce instead of expand the redundancy of this switch-case? I.e., put outside the outermost if-else: 1) the appending of the new const suffix, ",8,n,1,-"; 2) the setenv; 3) the break?
  3. usr/src/boot/sys/boot/efi/loader/main.c (Diff revision 1)
     
     
    I gather this is an upstream typo?
    1. Yes, and fixed there some time ago.

  4. 
      
tsoome
seeemef@mac.com
  1. LGTM
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...