8681 loader: bios loader should check the smap while loading the modules

Review Request #663 — Created Sept. 17, 2017 and submitted

tsoome
illumos-gate
8681
dc8cf8e...
general

8681 loader: bios loader should check the smap while loading the modules

Tested on vmware fusion VM during development, but more importantly, by Gary Mills on his AMD Ryzen host, where the problem was initially encountered.

  • 0
  • 0
  • 1
  • 1
  • 2
Description From Last Updated
tsoome
tsoome
tsoome
tsoome
tsoome
tsoome
tsoome
jbk
  1. 
      
  2. This seems like if we have a block that straddles the 1MB boundary (e.g. base = 0x0FFFFF + length > 1), this would not skip it which would seem to disagree with the comment. Would we not just want to make sure smap[i].base is >= 1MB?

  3. 
      
tsoome
yuripv
  1. 
      
  2. This doesn't really look like 1MB, or are we counting different here? :-)

    1. Ficl version 4.1.0
      Sep 24 2017 
      ok 1024 dup * .s
      [data stack has 1 entries, top at 0x0000000000c16df8]
      [0x0000000000c16df8   0]:              1048576 (0x0000000000100000)
      [data stack base at 0x0000000000c16df8]
      ok 
      

      So, the 0x100000 should be correct;)

    2. Cryptic!!!

  3. 
      
yuripv
  1. Ship It!
  2. 
      
tsoome
tsoome
Review request changed

Status: Closed (submitted)

Loading...