8651 loader: biosmem allocate heap just below 4GB

Review Request #661 — Created Sept. 12, 2017 and submitted

tsoome
illumos-gate
8651
d32ab91...
general
8651 loader: biosmem allocate heap just below 4GB


  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
tsoome
tsoome
igork
  1. Ship It!
  2. 
      
rm
  1. 
      
  2. So, the bug comments have some important information here about why we're looking for the last bit to make space for others. Would you mind updating the comment to make that clearer?
  3. 
      
tsoome
seeemef@mac.com
  1. 
      
  2. Hello. Maybe clarify "... set heap to use highest HEAP_MIN bytes below 4GB" instead of "just below". E.g., on a test VM where I assign only 1GB it would not be "just below 4GB".

  3. 
      
tsoome
seeemef@mac.com
  1. LGTM

  2. 
      
rm
  1. Ship It!
  2. 
      
tsoome
rm
  1. I don't see an smbios.h header removal. Was that the right comment?

  2. 
      
igork
  1. Ship It!
  2. 
      
seeemef@mac.com
  1. (Hmmm, a little RB bug in showing the 5-6 diff for "remove extra smbios.h"? Please chime in to Josh Clulow [as Robert M has done] to join in the request for an RB upgrade!).

    LGTM

  2. 
      
tsoome
rm
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...