8595 sys/ccompile.h: add __aligned and __packed

Review Request #652 — Created Aug. 31, 2017 and submitted

tsoome
illumos-gate
8595
654, 653
8e826a3...
general
8595 sys/ccompile.h: add __aligned and __packed


  • 0
  • 0
  • 0
  • 1
  • 1
Description From Last Updated
hans
  1. Ship It!
  2. 
      
seeemef@mac.com
  1. 
      
  2. usr/src/uts/common/sys/ccompile.h (Diff revision 1)
     
     
    I suggest that non-functional keywords should not use functional-looking syntax where there is no space before the parens. I.e., it should be:
    
        __attribute__ ((__aligned__ (x) )))
    
    here and likewise elsewhere in this file.
    1. The idea does look interesting, but I think I'll leave it into the "pocket" right now, the problem is that if we are going down this path, it also means we should adjust cstyle checks accordingly and that would be whole different update and out of the scope of this one.

      Having seen mixup of parametrized macro expansion and function calls, the idea does sound appealing. But also I think it would be better to raise it in developers list to collect more feedback as it is style change. For the reasons mentioned, I'll drop this suggestion now.

  3. 
      
igork
  1. Ship It!
  2. 
      
tsoome
igork
  1. Ship It!
  2. 
      
hans
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...