8368 remove warlock leftovers from usr/src/uts/common/io/ib

Review Request #637 — Created July 30, 2017 and discarded

yuripv
illumos-gate
master
8368
general

Remove warlock leftovers from usr/src/uts/common/io/ib (and corresponding usr/src/uts/common/sys/ib), which seems to have been the main consumer of warlock stuff.

It mostly removes the related _NOTE()'s and some #ifdef __lock_lint's.

build

  • 6
  • 0
  • 0
  • 0
  • 6
Description From Last Updated
Is it worth turning this into a comment? rm rm
Is it worth turning this into a comment? rm rm
I feel like some of the pieces of information here are probably useful. Notably what data is protected by locks, ... rm rm
See previous notes on subject. rm rm
Recording the lock order that we need to take woudl be really helpful! rm rm
See standard note. rm rm
yuripv
rm
  1. In general, I think this looks good. I think there are some places here where the warlock notes are worth transforming into comments, particularly around what mutex protect and lock ordering when it's not as obvious like being embedded in a structure to protect all its members. As, if we can save someone the effort of figuring out what a lock ordering is in particular, that's pretty useful.

    Thanks for cleaning this up, there are a lot of bad things done here in the name of warlock.

    1. Robert, thanks for taking a look at this. I don't really think it's worth turning the warlock directives into comments as these are really just silencing the warlock where it was not smart enough -- usr/src/uts/common/io/ib/clients/ibd/ibd.c could be an exception, and probably worth being a comment, but I'm not up to writing a proper theory comment there (not familiar with IB, and not really interested in becoming familiar).

  2. Is it worth turning this into a comment?
  3. Is it worth turning this into a comment?
  4. I feel like some of the pieces of information here are probably useful. Notably what data is protected by locks, not that it needs to stay in warlock form.
    
    For example, the write-once data structures, etc. are things I try to note in structure definitions and theory statements.
  5. usr/src/uts/common/io/ib/ibnex/ibnex.c (Diff revision 1)
     
     
    See previous notes on subject.
  6. Recording the lock order that we need to take woudl be really helpful!
  7. See standard note.
  8. 
      
yuripv
Review request changed

Status: Discarded

Loading...