5980 in-kernel inet_ntop should format IPv4 addresses like userland one

Review Request #622 - Created July 7, 2017 and submitted

Information
Yuri Pankov
illumos-gate
master
5980
185011c...
Reviewers
general

This changes the format inet_ntop() uses for IPv4 addresses to be the
same as userland one (which makes more sense).

The list of current kernel's inet_ntop() consumers with comments:

https://gist.github.com/yuripv/cbf201e7450eab867b510577cdb8188c

The only consumer that requires attention is
usr/src/uts/common/io/scsi/adapters/iscsi/persistent.c as it uses the IP
addresses as keys into persistent storage, so I've added a wrapper there
keeping old inet_ntop() behaviour - adding the logic which would rewrite
the nvlist names for such entries is just not worth it IMO.

Everything else is using inet_ntop() to print log messages, or was
already using a wrapper to fix the format (like SMB and iscsit).

Checked that iscsiadm can delete/update the entries in persistent storage that were created in previous BE.

Issues

  • 0
  • 0
  • 4
  • 4
Description From Last Updated
Igor Kozhukhov
Vitaliy Gusev
Vitaliy Gusev
Vitaliy Gusev
Yuri Pankov
Review request changed

Status: Closed (submitted)

Loading...