8448 uts: pci_autoconfig should test for BIOS

Review Request #610 — Created June 29, 2017 and submitted

tsoome
illumos-gate
8448
00423f0...
general
8448 uts: pci_autoconfig should test for BIOS


  • 0
  • 0
  • 4
  • 0
  • 4
Description From Last Updated
jclulow
  1. 
      
  2. usr/src/uts/intel/io/pci/pci_resource.c (Diff revision 1)
     
     

    boolean_t bios = B_TRUE ?

  3. usr/src/uts/intel/io/pci/pci_resource.c (Diff revision 1)
     
     

    Please put braces around if arms that have a multi-line condition; i.e.,

    ```
    if (ddi...
    ... tab")) {
    ...
    }

  4. usr/src/uts/intel/io/pci/pci_resource.c (Diff revision 1)
     
     

    Because "bios" is clearly a boolean condition throughout this function, I believe cstyle says you can treat it as such; e.g.

    if (bios) ...
    
  5. 
      
tsoome
yuripv
  1. 
      
  2. usr/src/uts/intel/io/pci/pci_resource.c (Diff revision 2)
     
     

    Probably, just if (bios).

    1. darn, somehow i did miss it...

  3. 
      
tsoome
rm
  1. Ship It!
  2. 
      
yuripv
  1. Ship It!
  2. 
      
jclulow
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...