8442 uts: startup_bios_disk() should check for BIOS

Review Request #604 — Created June 29, 2017 and submitted

tsoome
illumos-gate
8442, 8581
8fed1c7...
general

8442 uts: startup_bios_disk() should check for BIOS
8581 uts: startup_bios_disk() is testing for unused variable dobiosdev



  • 0
  • 0
  • 0
  • 1
  • 1
Description From Last Updated
yuripv
  1. I'd rather do this check in impl_setup_ddi() before calling startup_bios_disk(), but it doesn't matter much.

    1. I agree with Yuri's sentiments.
    2. moved it around.

  2. 
      
rm
  1. Ship It!
  2. 
      
tsoome
tsoome
yuripv
  1. 
      
  2. usr/src/uts/i86pc/os/ddi_impl.c (Diff revision 2)
     
     

    In the initial version you did check > 0, so here it should be <= 0?

    1. The BOP properties are a bit weird interface for checks; if the property is not defined, we will get -1; however if efi-systab is set, the value is definitely > 0 (as the pointer is either 4 or 8 bytes). So in this case we have the impossible value 0...

  3. 
      
yuripv
  1. Ship It!
  2. 
      
rm
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...