8418 zfs_prop_get_table() call in zfs_validate_name() is a no-op

Review Request #599 — Created June 23, 2017 and submitted

Information
marcel
illumos-gate
master
8418
61a1f22...
Reviewers
general 
This removes a no-op call from zfs_validate_name().
Without the fix:

# dtrace -n 'pid$target::zfs_validate_name:entry{self->t=1} pid$target::zfs_prop_get_table:entry/self->t/{} pid$target::zfs_validate_name:return{self->t=0}' -c "zfs list rpool" 2> /dev/null
NAME    USED  AVAIL  REFER  MOUNTPOINT
rpool  6.88G  54.6G  31.5K  /rpool
CPU     ID                    FUNCTION:NAME
  0  74118         zfs_prop_get_table:entry

#


With the fix:

# dtrace -n 'pid$target::zfs_validate_name:entry{self->t=1} pid$target::zfs_prop_get_table:entry/self->t/{} pid$target::zfs_validate_name:return{self->t=0}' -c "zfs list rpool" 2> /dev/null
NAME    USED  AVAIL  REFER  MOUNTPOINT
rpool  7.15G  54.4G  31.5K  /rpool

#
vgusev
vgusev 
  1. If look to zfs_prop_get_table():
    

    zprop_desc_t *
    
   zfs_prop_get_table(void)
    

    {
    
      return (zfs_prop_table);
    
   }
    

    I wonder why was it added to zfs_validate_name ?
  2. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




marcel




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
commit e09ba01dcda5e24964b8632718777b39166d86e4
Author:     Marcel Telka <marcel@telka.sk>
AuthorDate: Thu Jun 22 15:30:49 2017 +0200
Commit:     Matthew Ahrens <mahrens@delphix.com>
CommitDate: Mon Jun 26 13:22:15 2017 -0700

    8418 zfs_prop_get_table() call in zfs_validate_name() is a no-op
    Reviewed by: Vitaliy Gusev <gusev.vitaliy@icloud.com>
    Approved by: Matthew Ahrens <mahrens@delphix.com>

:100644 100644 47a8354... 73e81c6... M	usr/src/lib/libzfs/common/libzfs_dataset.c





 


 










  

 









     

    

   

  

  

   
   Loading...