8421 loader: chain load relocate data declaration is bad

Review Request #597 — Created June 23, 2017 and submitted

tsoome
illumos-gate
8421
0438096...
general
8421 loader: chain load relocate data declaration is bad

tested both chain load and loading memtest86 (syslinux based memory tester).

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
jbk
  1. Ship It!
  2. 
      
dillona
  1. 
      
  2. It looks to me like the proper type here would actually be a struct containing three relocater entry structs (each three uint32s) and a uint32 terminator. While I think the proposed code is correct and will work, maybe this would be a useful enhancement?
    1. Yes, I actually thought that too. I initially did set it to be array of 32-bit int's as I was not sure how exactly it will end up, but for now it seems it really is ok to interpret it as array of struct afterall.

    2. I used slight variation - left the terminator "hidden".

  3. 
      
tsoome
tsoome
dillona
  1. Ship It!
  2. 
      
jbk
  1. Ship It!
  2. 
      
tsoome
dillona
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...