8393 bnxe: left shift of negative value and bad macro

Review Request #582 — Created June 15, 2017 and submitted

tsoome
illumos-gate
8393
e33dc1f...
general
Samples from the errors:
../../common/io/bnxe/577xx/drivers/common/include/debug.h:882:26: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
 #define ERR_IF(cond)(cond==TRUE)
                          ^
../../common/io/bnxe/577xx/drivers/common/lm/device/lm_hw_init_reset.c:1234:8: note: in expansion of macro 'ERR_IF'
     if(ERR_IF(!pdev))

../../common/io/bnxe/577xx/common/bnxe_clc.c:11956:41: error: left shift of negative value [-Werror=shift-negative-value]
   vars->eee_status &= ~SHMEM_EEE_1G_ADV <<
                                         ^~
cc1: all warnings being treated as errors


jbk
  1. Ship It!
  2. 
      
rm
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...