8379 / 8360 / 8359 Assorted build fixes

Review Request #579 — Created June 13, 2017 and submitted

jbk
illumos-gate
general

This fixes:
8379 illumos-gate 'install' make target is too eager building things
8359 libzpool Makefiles are slightly broken
* 8360 ipdadm missing 'all' target

The first one is probably the biggest -- doing a make install (i.e. nightly) can potentially start to attempt to build uts, lib, etc. before the proto area is setup (and header files installed), which can lead to head scratching failures.

The last two just restore what I'd consider expected behavior when working in gate -- assuming bldenv env.sh has been run, without these cd usr/src/{lib/libzpool,cmd/ipdadm}; [d]make or [d]make all don't actually do anything of consequence -- one must [d]make install to have anything built (and of course installed into the proto area). With these fixes [d]make or [d]make all in those directories will build their respective targets while [d]make install now depends on the all target and then installs the files into the proto area as one would expect.

Ran nightly from a prior commit, verified no issues, saved it's proto area, then applied fixes, re-ran nightly. Verified again that mail_msg was clean, and then did wsdiff between the two resulting proto areas. The differences identified were only those things expected (i.e. places where $VERSION gets embedded, and the usual userland .SUNW_dof differences)
Also should add that in addition, I tried dmake all for ipdadm and libzpool after running bldenv illumos.sh and then dmake install to make sure they behaved as expected.

yuripv
  1. Ship It!
  2. 
      
tsoome
  1. Ship It!
  2. 
      
jbk
jbk
rm
  1. Ship It!
  2. 
      
jbk
Review request changed

Status: Closed (submitted)

Loading...