8339 col: misleading-indentation

Review Request #572 — Created June 5, 2017 and submitted

tsoome
illumos-gate
8339
1ed9667...
general
col.c:311:3: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
   if (*line != '\b')
   ^~
col.c:314:4: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
    switch (*line) {
    ^~~~~~
cc1: all warnings being treated as errors


tsoome
ptribble
  1. Ship It!
  2. 
      
rm
  1. 
      
  2. usr/src/cmd/col/col.c (Diff revision 1)
     
     

    I think this makes sense, though I have to admit that the if ! esc_chars bit does make me wonder what was going on here originally.

  3. 
      
aeon
  1. 
      
  2. usr/src/cmd/col/col.c (Diff revisions 1 - 2)
     
     

    Clearly not affected by the misleading-indentation warning so Ship It.
    However, red boxed whitespaces behind inside comment. Unaligned comment too. Both likely systemic from origin. Nothing more to say about it.

  3. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...