8296 tcopy: misleading-indentation

Review Request #552 — Created June 4, 2017 and submitted

tsoome
illumos-gate
8296
118fe28...
general
tcopy.c: In function 'main':
tcopy.c:152:4: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
    if (ln > 0)
    ^~
tcopy.c:160:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
     (void) printf("file %d: eof after %ld records:"
     ^
cc1: all warnings being treated as errors


  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
rm
  1. I think the choice here makes sense. That said, I'm not sure that there aren't more bugs here with the handling of errors from read, but I guess that's another problem.
  2. 
      
igork
  1. Ship It!
  2. 
      
gwr
  1. Ship It!
  2. 
      
tsoome
yuripv
  1. 
      
  2. usr/src/cmd/tcopy/tcopy.c (Diff revision 1)
     
     

    This doesn't look correct to me - see how we are writing EOF below.

    1. Good catch, Yuri. I'm still happy (more so, even:)

  3. 
      
tsoome
yuripv
  1. Ship It!
  2. 
      
rm
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...