8296 tcopy: misleading-indentation
Review Request #552 - Created June 4, 2017 and submitted
| Information | |
|---|---|
| Toomas Soome | |
| illumos-gate | |
| 8296 | |
| 118fe28... | |
| Reviewers | |
| general | |
tcopy.c: In function 'main':
tcopy.c:152:4: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
if (ln > 0)
^~
tcopy.c:160:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
(void) printf("file %d: eof after %ld records:"
^
cc1: all warnings being treated as errors
Yuri Pankov
I think the choice here makes sense. That said, I'm not sure that there aren't more bugs here with the handling of errors from read, but I guess that's another problem.
Ship It!
Ship It!
Review request changed
Change Summary:
simple cstyle update.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+4 -6) |
-
usr/src/cmd/tcopy/tcopy.c (Diff revision 1) -
This doesn't look correct to me - see how we are writing EOF below.
Review request changed
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+4 -7) |
Ship It!
Ship It!