8287 arn: misleading-indentation

Review Request #536 — Created May 28, 2017 and submitted

tsoome
illumos-gate
8287
73534fe...
general
../../common/io/arn/arn_rc.c: In function 'arn_rc_valid_phyrate':
../../common/io/arn/arn_rc.c:524:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
  if (!ignore_cw && WLAN_RC_PHY_HT(phy))
  ^~
../../common/io/arn/arn_rc.c:527:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
   if (!WLAN_RC_PHY_40(phy) && (capflag & WLAN_RC_40_FLAG))
   ^~
cc1: all warnings being treated as errors


andy_js
  1. This would be my guess too.

  2. 
      
yuripv
  1. Ship It!
  2. 
      
rm
  1. I agree that the change here makes logical sense. Is it worth trying to track down someone in the community with this part?

    1. Change looks right to me too. I guess if nobody offers to test this, just go ahead, as the failure would be no worse than deciding some PHY data rate is invalid.

    2. gmills did, but he had some unexpected other issues (WPA versus WPA2, not related to this patch) so the testing is a bit delayed. In any case, the RTI is posted, and just waiting for test result.

  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...