8284 fdc: misleading-indentation

Review Request #533 — Created May 28, 2017 and submitted

tsoome
illumos-gate
8284
5a9112b...
general
../../common/io/fdc.c: In function 'fdmotort':
../../common/io/fdc.c:2088:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
  if ((fcp->c_flags & FCFLG_WAITING) &&
  ^~
../../common/io/fdc.c:2093:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
   if (newxstate == -1) {
   ^~
cc1: all warnings being treated as errors


andy_js
  1. Ship It!
  2. 
      
rm
  1. I think I agree with the ultimate decision that this should have guarded the entire block. Can you add a few sentences of analysis to the bug to help cover this?

  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...