8267 8067 is breaking the build

Review Request #527 — Created May 24, 2017 and discarded

tsoome
illumos-gate
8267
general
8267 8067 is breaking the build

build/install/boot

andy_js
  1. Ship It!
  2. 
      
tsoome
yuripv
  1. Wonder how this slipped through openzfs automated builds. May be make sure ZFS guys take a look at this as well?

    1. my guess is, it was tested before scatter allocator - thats only way possible. The commit date is 1th of may - it kind of does fall into the time slot. Otherwise ye - I did got the RTI build completed, but I'll wait a bit with posting to get some more feedback, even as the issue seems to be clear enough because the originally used zio_decompress_data() is actually using zio_decompress_data_buf(). However, it may be the whole function may benefit from additional review.

  2. 
      
jjelinek
  1. I think this looks ok, but given the obvious issues around this, unless someone from the zfs team weighs in shortly, I think we should backout the breaking commit until they can fully address this.

  2. 
      
tsoome
Review request changed

Status: Discarded

Loading...