8230 e1000api: misleading-indentation

Review Request #514 — Created May 15, 2017 and submitted

tsoome
illumos-gate
8230
065fd82...
general
../../common/io/e1000api/e1000_ich8lan.c: In function 'e1000_disable_ulp_lpt_lp':
../../common/io/e1000api/e1000_ich8lan.c:1499:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
  if (ret_val)
  ^~
../../common/io/e1000api/e1000_ich8lan.c:1501:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
   phy_reg &= ~(I218_ULP_CONFIG1_IND |
   ^~~~~~~
../../common/io/e1000api/e1000_ich8lan.c: In function 'e1000_check_for_copper_link_ich8lan':
../../common/io/e1000api/e1000_ich8lan.c:1558:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
  if (!mac->get_link_status)
  ^~
../../common/io/e1000api/e1000_ich8lan.c:1565:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
   ret_val = e1000_phy_has_link_generic(hw, 1, 0, &link);
   ^~~~~~~
cc1: all warnings being treated as errors


yuripv
  1. Not sure about this one - we sync the source in e1000api with FreeBSD, this will likely make it harder.

    1. https://reviews.freebsd.org/D10741 I'll check with sbruno how we can get this to intel;)

    2. Oh, good then!

  2. 
      
yuripv
  1. Ship It!
  2. 
      
rm
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...