8224 libshell: operation on '_Fcin.fcptr' may be undefined

Review Request #511 — Created May 13, 2017 and submitted

tsoome
illumos-gate
8224
69decbd...
general
../common/sh/lex.c: In function 'sh_lex':
../common/include/fcin.h:49:39: error: operation on '_Fcin.fcptr' may be undefined [-Werror=sequence-point]
 #define fcseek(n) ((char*)(_Fcin.fcptr+=(n)))
                                       ^
../common/sh/lex.c:1089:7: note: in expansion of macro 'fcseek'
       fcseek(state-(fcseek(0)));
       ^~~~~~
cc1: all warnings being treated as errors


marcel
  1. 
      
  2. usr/src/lib/libshell/common/sh/lex.c (Diff revision 1)
     
     

    Why is fcseek(state) not enough here?

    1. Ha, the above is obviously not enough. Please ignore.

  3. 
      
marcel
  1. Ship It!
  2. 
      
rm
  1. It may help to add a few line analysis to the ticket for this.

  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...