I wanted to comment on that too, dammit reviewboard.
Andy, any chance of you getting your assert-deflib changes in too? Robert (and me, to a much lesser degree) made similar changes ages ago, but something or other was screwing them up. If you have them working, it'd be fantastic to get them in.
Indeed (I did a bit of this too, don't remember why I dropped it).
I'm more than happy to get the assert-deflib upstreamed. I will have to add an option to turn them off, otherwise the majority of illumos folks wont be able to build anymore. Joyent probably being the only exception.
For what it's worth, the way I was approaching this was to basically set the defaults to what they are in stock illumos-gate on OI/Omni and then undo those exceptions for libraries in illumos-joyent.