8161 aw: this statement may fall through

Review Request #472 — Created May 5, 2017 and submitted

tsoome
illumos-gate
8161
9b1d1eb...
general
aw.c: In function 'filter':
aw.c:287:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
   perror("fork");
   ^~~~~~~~~~~~~~
aw.c:288:2: note: here
  default:
  ^~~~~~~
aw.c: In function 'invoke':
aw.c:412:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
   perror("fork");
   ^~~~~~~~~~~~~~
aw.c:413:2: note: here
  default:
  ^~~~~~~
cc1: all warnings being treated as errors


  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
jbk
  1. Ship It!
  2. 
      
yuripv
  1. 
      
  2. usr/src/tools/aw/aw.c (Diff revision 1)
     
     

    You'll have different error code returned here, may be exit(1); here as well (2 is usually for identifying illegal command syntax).

    1. seems like good idea, yep.

  3. 
      
tsoome
rm
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...