8137 sun_fc: NULL pointer is used in wrong context

Review Request #459 — Created May 1, 2017 and submitted

tsoome
illumos-gate
8137
7ef4bd5...
general
8137 sun_fc: NULL pointer is used in wrong context


  • 0
  • 0
  • 0
  • 1
  • 1
Description From Last Updated
yuripv
  1. 
      
  2. Hmmm, here you are using fctio.fctio_obuf as a pointer, what gives?

    1. well, actually the fctio.fctio_obuf is pointer converted to 64-bit int - see line 433. but the fctio_obuf is uint64_t. Basically the issue is that they are writing C in C++. And since this is C++ code, we can not compare uint64_t to pointer.

    2. Oh, wow.

  3. 
      
yuripv
  1. Ship It!
  2. 
      
marcel
  1. Ship It!
  2. 
      
igork
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...