- Download Diff

Summary:

8007 want sys/stddef.h for offsetof and container_of macros (fix container_of visibility)

Review Request #443 — Created April 24, 2017 and submitted April 26, 2017, 5:59 a.m.

Information
Owner:	tsoome
Repository:	illumos-gate
Branch:
Bugs:
Depends On:
Commit:	43aa2b6...
Reviewers
Groups:	general
People:

Description

Testing Done

Issues

0
0
1
0
All Issues: 1

Description	From	Last Updated
I would rephrase this slightly: /* * We must not expose container_of() to userland, but we * want it to ...	jclulow	April 24, 2017, 6:22 p.m.

Change Summary:

cstyle fix

Commit:

-	534b0dc0e0d17f3a88897da22a587d18d79b7131
+	9a48fd000ed40e80d3a35fdfc67c8be442cf81e3

Diff:

Revision 2 (+8)

Show changes

usr/src/uts/common/sys/stddef.h

usr/src/uts/common/sys/stddef.h (Diff revision 2)

Show all issues

I would rephrase this slightly:

/*
 * We must not expose container_of() to userland, but we
 * want it to be available for early boot and for the kernel.
 */

Change Summary:

comment text updted

Commit:

-	9a48fd000ed40e80d3a35fdfc67c8be442cf81e3
+	43aa2b6af3c9ccd3600ba16ecff34ad7a64d190a

Diff:

Revision 3 (+8)

Show changes

usr/src/uts/common/sys/stddef.h

Ship it!

```
Ship It!
```

I probably miss something, but bug #8007 is already closed and the fix is pushed to the gate (with different subject).

tsoome April 24, 2017, 6:41 p.m.

yes, I havent yet set it up properly, was trying to get an grip how to deal with fallout first. in short - the problem is that with moving container_of out of sysmacros.h I did expose it to the userland, and C++ does not like it for sure, and probably some more. Will fix soon:)

Summary:

-	8007 need to hide container_of from the userland
+	8007 want sys/stddef.h for offsetof and container_of macros (fix container_of visibility)

Description:

~		8007 need to hide container_of from the userland
	~	8007 want sys/stddef.h for offsetof and container_of macros (fix container_of visibility)

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 3.0.18

8007 want sys/stddef.h for offsetof and container_of macros (fix container_of visibility)

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Summary:

Description:

Status: Closed (submitted)