8066 loader: zfs reader vdev_probe should check for minimum device size

Review Request #434 — Created April 13, 2017 and submitted

tsoome
illumos-gate
8066
a429250...
general

8066 loader: zfs reader vdev_probe should check for minimum device size



  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
yuripv
  1. 
      
  2. usr/src/boot/sys/boot/zfs/zfsimpl.c (Diff revision 1)
     
     

    Is it really minimum pool size, or rather minimum size of vdev that can be used for ZFS pool?

    1. Oh you are right there, what we really need to care is about vdev size. Need to doublecheck if we really are using the correct value here.

    2. hm, it seems the constant is for minimum device size, so apparently just need to update the issue line:D

  3. usr/src/boot/sys/boot/zfs/zfsimpl.c (Diff revision 1)
     
     

    Wonder if EINVAL would be a better error code? Doesn't matter much though.

    1. It really does not matter, as anything non-zero is an error, it is not reported anywhere (to avoid misleading errors with any non-zfs partitions).

  4. usr/src/boot/sys/boot/zfs/zfsimpl.c (Diff revision 1)
     
     

    cstyle "sizeof (".

    1. yea, missed it with copy, will fix.

  5. 
      
tsoome
yuripv
  1. Ship It!
  2. 
      
tsoome
tsoome
tsoome
Review request changed

Status: Closed (submitted)

Loading...